WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] tools: Check presence of ncurses

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] tools: Check presence of ncurses
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Tue, 4 Mar 2008 11:42:52 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 04 Mar 2008 03:44:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3F2E1FE.1D6FE%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <20080304110725.GA5038@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C3F2E1FE.1D6FE%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Keir Fraser, le Tue 04 Mar 2008 11:24:46 +0000, a écrit :
> Will this break cross-compile environments? Xentop is not built in that case
> (hence no dependency on curses.h), yet your new check will still be
> enforced. If it is the xentop usage that you are wanting to protect with a
> check, perhaps the compile-or-not decision in xenstat/Makefile should be
> made dynamically based on presence of curses.h?

Something like this then:


tools: Compile xentop only if curses are available.

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

diff -r c89f6ed56351 tools/xenstat/Makefile
--- a/tools/xenstat/Makefile    Mon Mar 03 11:47:40 2008 +0000
+++ b/tools/xenstat/Makefile    Tue Mar 04 11:41:24 2008 +0000
@@ -6,7 +6,9 @@ SUBDIRS += libxenstat
 
 # This doesn't cross-compile (cross-compile environments rarely have curses)
 ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
+ifeq ($(wildcard /usr/include/curses.h),/usr/include/curses.h)
 SUBDIRS += xentop
+endif
 endif
 
 .PHONY: all install clean

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>