WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [2.6 patch] make xen-blkfront.c:blkif_getgeo() static

To: Adrian Bunk <bunk@xxxxxxxxxx>
Subject: [Xen-devel] Re: [2.6 patch] make xen-blkfront.c:blkif_getgeo() static
From: Ian Campbell <ijc@xxxxxxxxxxxxxx>
Date: Fri, 22 Feb 2008 20:44:59 +0000
Cc: chrisw@xxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
Delivery-date: Tue, 26 Feb 2008 03:30:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080222195829.GH1409@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080222195829.GH1409@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2008-02-22 at 21:58 +0200, Adrian Bunk wrote:
> This patch makes the needlessly global blkif_getgeo() static.
> 
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx>

Acked-by: Ian Campbell <ijc@xxxxxxxxxxxxxx>

> 
> ---
> 6f34bfdbb8c24e06d982ccaccd24c25dba5b1956 diff --git 
> a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 9c6f3f9..ae7ee16 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -136,7 +136,7 @@ static void blkif_restart_queue_callback(void *arg)
>       schedule_work(&info->work);
>  }
>  
> -int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
> +static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
>  {
>       /* We don't have real geometry info, but let's at least return
>          values consistent with the size of the device */
> 
> 
-- 
Ian Campbell

WHERE CAN THE MATTER BE
        Oh, dear, where can the matter be
        When it's converted to energy?
        There is a slight loss of parity.
        Johnny's so long at the fair.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>