WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATH] ioemu: use SIGHUP instead of SIGKILL

To: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATH] ioemu: use SIGHUP instead of SIGKILL
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 04 Feb 2008 11:21:02 +0000
Delivery-date: Mon, 04 Feb 2008 03:20:59 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080204110730.GA6936@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchnIAYoRNbjgtMTEdyscgAWy6hiGQ==
Thread-topic: [Xen-devel] [PATH] ioemu: use SIGHUP instead of SIGKILL
User-agent: Microsoft-Entourage/11.3.6.070618
Although this looks potentially reasonable, I'm not sure about the approach
of SIGHUPing a dom0 'proxy' process to kill an hvm stub domain. How hard
would it be to teach xend just enough about hvm stub domains to have it
directly kill the stub domain at the same time as it kills the normal hvm
domain? I think this would yield a more robust 'xm destroy' which could
handle a wider range of stub-domain-related hangs/crashes.

 -- Keir

On 4/2/08 11:07, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx> wrote:

> The stub domain device model needs to trap the termination signal so as
> to actually destroy the stub domain.  SIGKILL can't be trapped, SIGTERM
> is caught by SDL and so may be unnoticed.  SIGHUP can be trapped and is
> not caught by SDL (and by default causes a process termination without
> core).
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
> 
> diff -r 2407a61c0d30 tools/python/xen/xend/image.py
> --- a/tools/python/xen/xend/image.py Mon Feb 04 11:04:13 2008 +0000
> +++ b/tools/python/xen/xend/image.py Mon Feb 04 11:04:32 2008 +0000
> @@ -329,7 +329,7 @@ class ImageHandler:
>              return
>          if self.pid:
>              try:
> -                os.kill(self.pid, signal.SIGKILL)
> +                os.kill(self.pid, signal.SIGHUP)
>              except OSError, exn:
>                  log.exception(exn)
>              try:
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>