WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] free_xen_event_channel() forgets to free the channel or

To: "Tan, Lin" <lintan2@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] free_xen_event_channel() forgets to free the channel or it is obsolete?
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sun, 27 Jan 2008 09:45:13 +0000
Delivery-date: Sun, 27 Jan 2008 01:45:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <F40E144328C04648A1A3ABA9330611D02EEAF9DCA3@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchffcYE4ZnH2BK7QxqrWVIZipgsWQAQQJdwADQOEkAADpPh8g==
Thread-topic: [Xen-devel] free_xen_event_channel() forgets to free the channel or it is obsolete?
User-agent: Microsoft-Entourage/11.3.6.070618
It is called free_xen_event_channel() as the symmetric opposite of
alloc_unbound_xen_event_channel(). Since the latter does no xmalloc(), it
makes sense the former would do no xfree().

 -- Keir

On 27/1/08 02:48, "Tan, Lin" <lintan2@xxxxxxxx> wrote:

> Hi,
> 
> Should free_xen_event_channel() actually free the event_channel, by calling
> free_xen_event_channel() and then xfree()? Right now, it only closes the
> channel.
> 
> Or free_xen_event_channel() is not used at all and should be removed, as
> evtchn_destroy() does the same job?
> 
> It is in file common/event_channel.c.
> 
> Thanks,
> Lin
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel