WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] Fix blktap script

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Fix blktap script
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Thu, 24 Jan 2008 15:53:54 +0900
Delivery-date: Wed, 23 Jan 2008 22:54:49 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

I believe that we should use fatal() in xen-hotplug-common.sh if the 
file does not exist. 

Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

diff -r 1c826ea72a80 tools/examples/blktap
--- a/tools/examples/blktap     Wed Jan 23 15:42:52 2008 +0000
+++ b/tools/examples/blktap     Thu Jan 24 14:57:48 2008 +0900
@@ -71,9 +71,9 @@ fi
 fi
 # some versions of readlink cannot be passed a regular file
 if [ -L "$p" ]; then
-    file=$(readlink -f "$p") || ebusy "$p link does not exist."
+    file=$(readlink -f "$p") || fatal "$p link does not exist."
 else
-    [ -f "$p" ] || { ebusy "$p file does not exist."; }
+    [ -f "$p" ] || { fatal "$p file does not exist."; }
     file="$p"
 fi
 
@@ -85,7 +85,7 @@ fi
 
 if [ "$command" = 'add' ]
 then
-    [ -e "$file" ] || { ebusy $file does not exist; }
+    [ -e "$file" ] || { fatal $file does not exist; }
     success
 fi
 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>