WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] about vga_endboot logic

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] about vga_endboot logic
From: "余上" <yusunn@xxxxxxxxx>
Date: Sat, 19 Jan 2008 23:30:57 +0800
Delivery-date: Sat, 19 Jan 2008 07:31:21 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; bh=09UVj0jHtsNNX5MefgJvl0bIIQxn7TAU0o5C6FCVaVM=; b=UeXiI0xVtAWDZ2zOZOpSDfhTVMt5sknAIeD97kUTEAqDMG+OUg+jc5dpQKOErgG5gMLWF2UI0SEJcEq1lhHyyjrT6qBReTm/1DAGWSkvQAmdd31jWfqi8Qnzu47J80ebMWZcyk0o9eyKabGlnv0HuCtXgCNMZrpQnG694f4Q0xQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=trwNsPiQJhCl+HgF6r+W7LOlFWZ1o1J7brzwKskfJhUPm8hpSVsyC9HWyDSepZ9J8W5rQHtCjRu3atOia7gOHM0XFpqKrSrTzpkkwUkdZO0V8gR62udT2XkMZ3XMSTu9IoWGgIWaxtshgz6Ca/LQojqurvUYg1aDbFdBUb8/5Tk=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi all ,

I think the logic of vga_endboot is not correct , if I pass vga=keep
xen will print :
Xen is keeping VGA console.
but if I do not pass keep parmeter xen will not print :
Xen is relinquishing VGA console.

The new logic should be:

void vga_endboot(void)
{
    if ( !vgacon_enabled )
        return;

    printk("Xen is %s VGA console.\n",
           vgacon_keep ? "keeping" : "relinquishing");

    if ( !vgacon_keep )
        vgacon_enabled = 0;

}
just move printk before the second if statement

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>