WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] 3.1.3 (and ??) timer_mode fix in xend for virt-i

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 3.1.3 (and ??) timer_mode fix in xend for virt-install
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Fri, 18 Jan 2008 22:20:50 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 18 Jan 2008 14:21:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080118151316625.00000001968@djm-pc>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080118215927.GE25808@xxxxxxxxxx> <20080118151316625.00000001968@djm-pc>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Fri, Jan 18, 2008 at 03:13:16PM -0700, Dan Magenheimer wrote:
> > so can't confirm that yet. I'll try and reproduce it - what 
> > error were you getting
> > when trying to create a VM ?  libvirt doesn't specify any 
> > timer_mode parameter
> > when creating VMs, so it should use whatever XenD's default 
> > is for that.
> 
> Traceback below.
> 
> Yeah, I'm no parseltongue but I think the default wasn't
> specified properly.
> 
> Note also that I am using python-virtinst-0.99 so maybe
> the interface to the XendServer has changed in more recent
> releases and wouldn't provoke the problem?
> 
> Dan
> 
> 
> Starting install...
> libvir: Xen Daemon error : GET operation failed:
> libvir: Xen Daemon error : POST operation failed: (xend.err 'Error creating 
> doma
> in: long() argument must be a string or a number')

Ok this is useful. I'd say that message comes from this:

             xc.hvm_set_param(self.domid, HVM_PARAM_TIMER_MODE,
                  long(self.info["platform"].get("timer_mode")))


And that 'self.info["platform"].get("timer_mode")' is returning None,
causing the long() cal to fail. 

So either we need to make sure that 'platform' gets a default value
set for 'timer_mode', or make the hvm_set_param() call conditional
like

   if self.info["platform"].get("timer_mode") is not None:
       xc.hvm_set_param(self.domid, HVM_PARAM_TIMER_MODE,
                  long(self.info["platform"].get("timer_mode")))

I assume the Hypervisor itself already has a default timemode value,
so making this set_param conditional is probably easiest.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel