Re: [Xen-devel] [PATCH] do_callback_op()'s second argument can be const

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> 18.01.08 16:00 >>>
>This patch doesn't seem very useful since the guest can trivially cast its
>way out of the const-ness.

Casts should be avoided if possible, especially in C (in C++ you could
indeed just cast away the constness without affecting the underlying
type). The hypervisor side of this change is to guarantee the constness
to the guest side is (to be, in a few seconds) promised by changes to
the hypercall wrappers.

>I certainly don't see how the chunk below fixes
>anything -- doesn't it take two lines to state what took one line before?

It fixes the build in the context of the other changes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel