[Xen-devel] [PATCH] libxen compilation fixes

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

xen_common.h has the following function declaration:
 extern xen_version *xen_get_client_side_version(void);

This is not a prototype and should be.  Compilers invoked with
sensible warning options barf on declarations which do not specify the
argument types, even for function pointers.

Also, libxen should be compiled with -Wno-declaration-after-statement
since it uses that programming style.

Ian.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Index: xen-unstable.hg/tools/libxen/include/xen/api/xen_common.h
===================================================================
--- xen-unstable.hg.orig/tools/libxen/include/xen/api/xen_common.h      
2008-01-15 16:06:48.000000000 +0000
+++ xen-unstable.hg/tools/libxen/include/xen/api/xen_common.h   2008-01-15 
16:06:50.000000000 +0000
@@ -107,7 +107,7 @@
  * minor, and extraversion of the Xen release with which it was released,
  * plus the library's own version as the patch.
  */
-extern xen_version *xen_get_client_side_version();
+extern xen_version *xen_get_client_side_version(void);
 
 
 extern bool
Index: xen-unstable.hg/tools/libxen/Makefile
===================================================================
--- xen-unstable.hg.orig/tools/libxen/Makefile  2008-01-15 16:06:48.000000000 
+0000
+++ xen-unstable.hg/tools/libxen/Makefile       2008-01-15 16:06:50.000000000 
+0000
@@ -24,7 +24,8 @@
 CFLAGS = -Iinclude                     \
          $(shell xml2-config --cflags) \
          $(shell curl-config --cflags) \
-         -W -Wall -Wmissing-prototypes -Werror -std=c99 -O2 -fPIC
+         -W -Wall -Wmissing-prototypes -Werror -std=c99 -O2 -fPIC \
+         -Wno-declaration-after-statement
 
 LDFLAGS = $(shell xml2-config --libs) \
           $(shell curl-config --libs)
Index: xen-unstable.hg/tools/libxen/Makefile.dist
===================================================================
--- xen-unstable.hg.orig/tools/libxen/Makefile.dist     2008-01-15 
16:06:48.000000000 +0000
+++ xen-unstable.hg/tools/libxen/Makefile.dist  2008-01-15 16:06:50.000000000 
+0000
@@ -22,7 +22,8 @@
 CFLAGS = -Iinclude                     \
          $(shell xml2-config --cflags) \
          $(shell curl-config --cflags) \
-         -W -Wall -Wmissing-prototypes -Werror -std=c99 -O2 -fPIC
+         -W -Wall -Wmissing-prototypes -Werror -std=c99 -O2 -fPIC \
+         -Wno-declaration-after-statement
 
 LDFLAGS = $(shell xml2-config --libs) \
           $(shell curl-config --libs)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel