WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] That xenstored console leak...

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] That xenstored console leak...
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Mon, 14 Jan 2008 22:55:37 +0000
Cc: Jim Fehlig <jfehlig@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 14 Jan 2008 14:56:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C3B18AAA.12270%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080114214848.GB624@xxxxxxxxxxxxxxxxxxxxxxx> <C3B18AAA.12270%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Mon, Jan 14, 2008 at 09:54:50PM +0000, Keir Fraser wrote:

> >> Yes, device controllers clean up by deleting /vm/<uuid>/path/to/device. 
> >> This
> >> aliases with the new domain's device information (because they're really 
> >> the
> >> same vm) and so when the old domain is cleaned up the new domain loses
> >> information. Disambiguating with an extra level of indirection seemed the
> >> simplest fix for this. I'm not sure why this leads to xenstore leaks.
> >> 
> >> When a domain is finally garbage collected in xend, perhaps we should 
> >> delete
> >> its entire /vm/<uuid>/<unique-number>? That would seem a nice and 
> >> reasonable
> >> catch-all.
> > 
> > The lack of the latter explains the former - because each instance has a
> > unique /vm path, there's nothing that ever cleans up the older path
> > contents (image etc.).  Right?
> 
> I don't understand what you mean. There's no code to delete the entire /vm
> path, regardless of whether the path is /vm/<uuid>/ or /vm/<uuid>-<number>
> (I'm pretty sure).

The old code re-used the same /vm/<uuid>/ path, so there was no leak.
The new code creates a completely new /vm/<uuid>-<number> path, leaking the
old one (/vm/<uuid>-<oldnumber>).

Am I missing something obvious here?

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel