On Wed, Jan 09, 2008 at 06:44:39AM -0700, Pat Campbell wrote:
> >>> On Tue, Jan 8, 2008 at 1:31 PM, in message
> <20080108203102.GO21294@xxxxxxxxxx>, "Daniel P. Berrange"
> <berrange@xxxxxxxxxx>
> wrote:
> > On Tue, Jan 08, 2008 at 01:19:34PM - 0700, Pat Campbell wrote:
> >>
> >> New 3.2 QEMU PV guests are calling xenstore- parse_domain_config() opening
> >> block devices and setting watches that might not be necessary.
> >>
> >> Seems like each machine type should have it's own specific xenstore parse
> >> routine if it needs one.
> >>
> >> I have attached a patch that adds a xenstore parse pointer into the
> > QEMUMachine
> >> struct. main() will call that machine specific function if set otherwise
> > calls
> >> generic xenstore- parse_domain_config. Attached patch is just something
> >> as a
> >> starting point for discussion not something I propose be applied.
> >
> > Since the xenstore_parse_domain_config method is doing stuff specific to
> > HVM guests, it shoudl really be moved out of vl.c and into the init method
> > for xenfv_machine. vl.c should only contain generic code - this must be
> > something I missed when tidying up this code for the initial PV QEMU
> > support.
>
> Side effect of xenstore_parse_domain_config method is to open the
> domain, setting variable xsh which is used in xenstore_read_vncpasswd()
> and xenstore_write_vncport(). These are used in both machine types.
Hmm, lets just have a direct call
xsh = xs_daemon_open();
if (xsh == NULL) {
fprintf(logfile, "Could not contact xenstore for domain config\n");
return;
}
in vl.c, then we ought to be able to move xenstore_parse_domain_config
into the xen_machine_fv.c
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
Home