WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [QEMU-DM] Upgrade emulated UART to 16550A.

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [QEMU-DM] Upgrade emulated UART to 16550A.
From: "Trolle Selander" <trolle.selander@xxxxxxxxx>
Date: Wed, 5 Dec 2007 15:35:22 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 05 Dec 2007 06:36:06 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; bh=QzjQgVQ6llwfOedRlMUpt+MuFd7XnJ1XlCK8nyP9mXQ=; b=xOfFTQ80wenXFSmw8B/FmDlhrMbeuP70yxCo/Kinp7a00WUyCAe+xuNgGEZFUNgWspDkZKkEvCAYmWIuLT8w6VAOXPo05sUcZN6L4AYMaz0mFeCbuC+40QUAgVSWTVpjugG08hW9DwFR1LUrgdtVGOlfGTtPcRhRgVQ+Qwjy1zk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=LISOfMR2K7NzotkFi+GPCrUEwM+7ubQDZI5PKwtPXc+VuBg93BA3Ayizypi230vP4ZkRF/oWFQBxsWYgG64yamiXG2Kt+1gyQrlzEcjxZ7gR/pHkM9xpbMujXzpSaOAhJwLHB3Z5KnUsnrZnaQa107309YxgAQLhLXCszIPb/Wo=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20071205142446.GA12556@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <515922b50712040832ifc112b1j52e1d2390d7c7459@xxxxxxxxxxxxxx> <20071205142446.GA12556@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I don't think they'll apply cleanly to mainline qemu due to the serial_get_token stuff, which is xen-specific, but it should be utterly trivial to fix this. I'll make new patches against the latest mainline qemu and submit them to qemu-devel as soon as I have time. I don't think qemu will benefit as much from them performance-wise, but they definitely do belong upstream.

On Dec 5, 2007 3:24 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote:
On Tue, Dec 04, 2007 at 05:32:39PM +0100, Trolle Selander wrote:
> This patch adds 16550 emulation to qemu-dm. I still consider it a work in
> progress, but from my testing, it consistently performs better than the old
> code already, sometimes considerably so (on my laptop, dumping out data over
> serial from a HVM DomU -> pty in Dom0 was up to 5.3 times faster than with
> the old 16450 code). I can consistenly reach full 115200 baud speeds over
> physical serial lines when the virtual device is backed by a phys port,
> which I never could with the old code.
>
> There are still some things to be done. I want to add proper error handling,
> so that overflow/framing & parity errors on the physical port get detected
> and reported by the virtual port. Also, now that FIFOs are in place, I
> believe performance could be improved significantly by putting some code
> into the hypervisor so that reads & writes from the FIFOs don't have to exit
> into qemu-dm at all. I'm also reading up on the specs for newer uarts with
> deeper FIFOs.
>
> However, for now, I think this patch is already quite good, and I don't
> think I should sit on it any longer. I'm looking forward to hearing what
> results others will get with it.

From a quick glance through the patches there doesn't appear to be anything
that is Xen specific in these patches. If I am correct in this understanding,
could you send the patches to upstream qemu-devel mailing lists, so Xen does
not have to carry this fork forever.

Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel