 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [Mini-OS] Drop useless -fpic flag
| To: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [Mini-OS] Drop useless -fpic flag |
| From: | Grzegorz Miłoś <gm281@xxxxxxxxx> |
| Date: | Wed, 28 Nov 2007 17:29:52 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx, Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx> |
| Delivery-date: | Wed, 28 Nov 2007 09:31:09 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; bh=lW6kDTGL5cku1dbcZZjoDAUDnkERFaz+Y/wgzwOdmgY=; b=bjeUDymk9IgVLVsHpfFjb4+hCLE+wHAIBpI1vKmB2KGjNlvkopUjbeLUf0udLlQzQ355Z2Tr4eA/WRvlHo2IBK5k0FsrTOuQzsgQGa9PyJ4mDBvcSbjPN4C0LL300tb9jPYYohmISuvycbTNYraLSmmXelQKleURDLrTOhRD7QA= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=received:cc:message-id:from:to:in-reply-to:content-type:content-transfer-encoding:mime-version:subject:date:references:x-mailer:sender; b=YN4WGa6zZTv/wj96dYlDMdbipmfFrzvDeROtgcuYlVNs4vy+67CNyP1gtIj9Dlwg5u91ywR+uccEi6FmdypNOu3tRPn65BOwilU9hUXIQTRmp+t5BTrsQDBsPZgR9gsvaAbCFZNurnciVilR/baySUwG3hYSj8UdwJ1udBIaYfI= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C3734AFE.1922B%Keir.Fraser@xxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <C3734AFE.1922B%Keir.Fraser@xxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Yes, that's right. At the time I was writing the first version I just
copied all the flags. I, too, believe -fpic acn be discarded.
Cheers Gregor On 28 Nov 2007, at 16:42, Keir Fraser wrote: Ah yes, I think the -fpic was inherited from Xen's Makefile. Xen has to be built -fpic because it is not linked sufficiently close to address 0x0 to use absolute addressing the 32-bit displacements. This isn't the case forminios. -- KeirOn 28/11/07 16:35, "Samuel Thibault" <samuel.thibault@xxxxxxxxxxxxx> wrote:Keir Fraser, le Tue 27 Nov 2007 12:33:23 +0000, a écrit :If it builds without it then it should be fine, I believe.And nobody raised his hand, so here is a patch: Drop useless -fpic flag. Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxx> diff -r c555a5f97982 extras/mini-os/arch/x86/arch.mk --- a/extras/mini-os/arch/x86/arch.mk Wed Nov 28 13:36:56 2007 +0000 +++ b/extras/mini-os/arch/x86/arch.mk Wed Nov 28 16:33:37 2007 +0000 @@ -17,7 +17,7 @@ endif endif ifeq ($(TARGET_ARCH),x86_64) -ARCH_CFLAGS := -m64 -mno-red-zone -fpic -fno-reorder-blocks +ARCH_CFLAGS := -m64 -mno-red-zone -fno-reorder-blocks ARCH_CFLAGS += -fno-asynchronous-unwind-tables ARCH_ASFLAGS := -m64 ARCH_LDFLAGS := -m elf_x86_64_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-ia64-devel] [PATCH] Add guest_os_type domain config option, Alex Williamson |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] Create XEN_DOMCTL_set_opt_feature, Alex Williamson |
| Previous by Thread: | Re: [Xen-devel] [Mini-OS] Drop useless -fpic flag, Keir Fraser |
| Next by Thread: | [Xen-devel] [PATCH] [Mini-OS] Catch NULL dereferences, Samuel Thibault |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
