xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] Make xenstored EOF-safe

from [Samuel Thibault]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [PATCH] Make xenstored EOF-safe
From:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date:	Tue, 27 Nov 2007 15:00:12 +0000
Delivery-date:	Tue, 27 Nov 2007 07:00:58 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.12-2006-07-14

As bug 968 suggests, xenstored must properly handle EOF from clients.

From: Pavel Kankovsky <peak@xxxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxx>

diff -r 6fd17d0dcbcd tools/xenstore/xenstored_core.c
--- a/tools/xenstore/xenstored_core.c   Tue Nov 27 12:49:16 2007 +0000
+++ b/tools/xenstore/xenstored_core.c   Tue Nov 27 14:56:35 2007 +0000
@@ -1266,7 +1266,7 @@ static void handle_input(struct connecti
        if (in->inhdr) {
                bytes = conn->read(conn, in->hdr.raw + in->used,
                                   sizeof(in->hdr) - in->used);
-               if (bytes < 0)
+               if (bytes <= 0)
                        goto bad_client;
                in->used += bytes;
                if (in->used != sizeof(in->hdr))
@@ -1288,7 +1288,7 @@ static void handle_input(struct connecti
 
        bytes = conn->read(conn, in->buffer + in->used,
                           in->hdr.msg.len - in->used);
-       if (bytes < 0)
+       if (bytes <= 0)
                goto bad_client;
 
        in->used += bytes;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] Make xenstored EOF-safe, Samuel Thibault <= Re: [Xen-devel] [PATCH] Make xenstored EOF-safe, Keir Fraser Re: [Xen-devel] [PATCH] Make xenstored EOF-safe, Samuel Thibault

Previous by Date:	Re: [Xen-devel] SWIOTLB allocation failed, pradeep singh rautela
Next by Date:	[Xen-devel] [PATCH] [vnet] Fix compilation, Samuel Thibault
Previous by Thread:	[Xen-devel] SWIOTLB allocation failed, Lukas Hejtmanek
Next by Thread:	Re: [Xen-devel] [PATCH] Make xenstored EOF-safe, Keir Fraser
Indexes:	[Date] [Thread] [Top] [All Lists]