 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Fix stdvga performance for 32bit ops
| To: | Alex Williamson <alex.williamson@xxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Fix stdvga performance for 32bit ops |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Thu, 01 Nov 2007 17:28:56 +0000 |
| Cc: | xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Robert Phillips <rphillips@xxxxxxxxxxxxxxx>, Ben Guthro <bguthro@xxxxxxxxxxxxxxx> |
| Delivery-date: | Thu, 01 Nov 2007 10:29:58 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <1193934839.31834.59.camel@bling> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcgcrK4L7MwJDIifEdy2TAAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH] Fix stdvga performance for 32bit ops |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
On 1/11/07 16:33, "Alex Williamson" <alex.williamson@xxxxxx> wrote: >> Corrected a bug in the stdvga code where it did not >> properly handle 32 bit operations. >> The buf_ioreq_t can now store 32 bits of data. >> Because this increases its size to 8 bytes, >> only 510 elements fit in the buffered_iopage >> (down from 672 elements). > > Aren't we relying on some compiler dependent packing to get this to 8 > bytes? I think it'd be best if we were more explicit in the definition. > Thanks, If gcc gets it right, that's good enough. We always build Xen and ioemu with gcc. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-ia64-devel] Please pull ia64 trees, Alex Williamson |
|---|---|
| Next by Date: | Re: [Xen-devel] Fw: [Xen-API] status of xen api, Stefan Berger |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Fix stdvga performance for 32bit ops, Alex Williamson |
| Next by Thread: | Re: [Xen-devel] [PATCH] Fix stdvga performance for 32bit ops, Robert Phillips |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
