WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xen: cache current vcpu

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] xen: cache current vcpu
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Mon, 29 Oct 2007 20:23:20 +0200
Delivery-date: Mon, 29 Oct 2007 11:30:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C34BC77D.17957%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C34BC77D.17957%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6
I thought, the changes to register_guest_nmi_callback() and 
do_set_trap_table() make some sense. The rest is just for consistency.

Take what you like, leave the rest :)

Christoph



On Monday 29 October 2007 18:23:09 Keir Fraser wrote:
> Gcc is quite capable of eliminating common subexpressions involving
> current(), and I don't think this patch aids code readability (especially
> the set_debugreg() change -- p==current means more to me than p==v).
>
>  -- Keir
>
> On 29/10/07 15:43, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> > Hi!
> >
> > Attached patch caches current vcpu.
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>



-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Geschäftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplementär:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>