 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][VMX] a small clean to vmx_world_restore
| To: | "Li, Xin B" <xin.b.li@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][VMX] a small clean to vmx_world_restore |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Sat, 13 Oct 2007 11:57:54 +0100 |
| Delivery-date: | Sat, 13 Oct 2007 03:53:22 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <B30DA1341B0CFA4893EF8A36B40B5C5D01BFEB52@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcgNfqFRSPZ6n/dbRgWjVrQ0bynVxQACBJIHAAAUspAAADhYYQ== |
| Thread-topic: | [Xen-devel] [PATCH][VMX] a small clean to vmx_world_restore |
| User-agent: | Microsoft-Entourage/11.3.6.070618 |
The current code is correct in that case, and more generally, and also one line shorter than the proposed patch. -- Keir On 13/10/07 11:49, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote: > If guest exits real mode, in vmx_world_restore, c->cr0 is equal to > guest_cr0. > -Xin > >> I think it's correct as is and changing it in this way could break it. >> Whether a reference is acquired depends on new CR0.PG. Whether >> a reference >> is dropped depends on old CR0.PG. Which is how the code >> currently works. >> >> -- Keir >> >> On 13/10/07 10:51, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote: >> >>> a small clean to vmx_world_restore. >>> Signed-off-by: Xin Li <xin.b.li@xxxxxxxxx> >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@xxxxxxxxxxxxxxxxxxx >>> http://lists.xensource.com/xen-devel >> _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [Xen-devel] [PATCH][VMX] a small clean to vmx_world_restore, Li, Xin B |
|---|---|
| Next by Date: | RE: [Xen-devel] [PATCH][VMX] a small clean to vmx_world_restore, Li, Xin B |
| Previous by Thread: | RE: [Xen-devel] [PATCH][VMX] a small clean to vmx_world_restore, Li, Xin B |
| Next by Thread: | RE: [Xen-devel] [PATCH][VMX] a small clean to vmx_world_restore, Li, Xin B |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
