WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] Initialize last_error in libxc

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] Initialize last_error in libxc
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Fri, 05 Oct 2007 22:20:44 +0900
Delivery-date: Fri, 05 Oct 2007 06:21:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

When I tested some xm commands, I saw the following unjust error messages. 

# xm vcpu-pin vm1 0 99
Error: Cannot pin vcpu: 0 to cpu: [99] - (2865808, 'Unknown error code', 
'\x90\xba+')
Usage: xm vcpu-pin <Domain> <VCPU|all> <CPUs|all>

Set which CPUs a VCPU can use.
# xm trigger vm1 INIT
Error: (2865808, 'Unknown error code', '\x90\xba+')
Usage: xm trigger <Domain> <nmi|reset|init> [<VCPU>]

Send a trigger to a domain.


I think that the cause is because _xc_get_last_error() in libxc does not 
initialize last_error. 
This patch initializes last_error.  The test result is as follows. 

# xm vcpu-pin vm1 0 99
Error: Cannot pin vcpu: 0 to cpu: [99] - (22, 'Invalid argument')
Usage: xm vcpu-pin <Domain> <VCPU|all> <CPUs|all>

Set which CPUs a VCPU can use.
# xm trigger vm1 INIT
Error: (38, 'Function not implemented')
Usage: xm trigger <Domain> <nmi|reset|init> [<VCPU>]

Send a trigger to a domain.


Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

Attachment: initialize_last_error.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] Initialize last_error in libxc, Masaki Kanno <=