WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][HVM][SVM] Fix machine check intercept correctly

To: "Woller, Thomas" <thomas.woller@xxxxxxx>, "Egger, Christoph" <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][HVM][SVM] Fix machine check intercept correctly
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 02 Oct 2007 06:37:21 +0100
Delivery-date: Mon, 01 Oct 2007 22:33:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <683860AD674C7348A0BF0DE3918482F605F6BD1E@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcgERaeH5gKa8HA4EdyGEgAX8io7RQAAHnFgABwLCbY=
Thread-topic: [Xen-devel] [PATCH][HVM][SVM] Fix machine check intercept correctly
User-agent: Microsoft-Entourage/11.3.6.070618
The documentation is unclear on what happens to #MC. Certainly it is held
pending if GIF==0, but the manual does not explicitly say that #MC is held
pending on vmexit. Is it possible to inject a #MC, to test what happens?
That would be very handy, otherwise the code path basically gets no testing.
:-)

 -- Keir

On 1/10/07 17:17, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote:

> In theory the MCE that occurs in SVM partition, will be held pending
> until the VMEXIT occurs, and then released when the STGI instruction is
> executed, rendering any VMEXIT code non-useful.  Same as the NMI
> handling.  I might be missing something here, but the do_machine_check()
> will be executed in the context of the hv trap handlers immediately
> after STGI instruction, so we don't want to call it twice in the vmexit
> handler code.  (?)
> tom 
> 
>> -----Original Message-----
>> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of
>> Keir Fraser
>> Sent: Monday, October 01, 2007 11:11 AM
>> To: Egger, Christoph; xen-devel@xxxxxxxxxxxxxxxxxxx
>> Subject: Re: [Xen-devel] [PATCH][HVM][SVM] Fix machine check
>> intercept correctly
>> 
>> On 1/10/07 16:33, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
>> 
>>> Hi!
>>> 
>>> Attached patch fixes machine check interception for HVM guests.
>>> 
>>> Keir: Please apply this patch to xen-staging *and* to Xen 3.1.1
>> 
>> First chunk (adding TRAP_machine_check to exception
>> intercepts) is not needed as that bit is already in
>> HVM_TRAP_MASK. Also why remove the invocation of
>> do_machine_check()? That is the function that actually
>> handles the #MC.
>> 
>>  -- Keir
>> 
>> 
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
>> 
>> 
>> 
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>