This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [patch] Only skip the image name if it is the image name

To: Horms <horms@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [patch] Only skip the image name if it is the image name
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 29 Aug 2007 15:20:06 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Campbell <ian.campbell@xxxxxxxxxxxxx>
Delivery-date: Wed, 29 Aug 2007 07:20:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070829004309.GA13900@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfqR7Jm8OZRSlY6EdyVXAAX8io7RQ==
Thread-topic: [Xen-devel] [patch] Only skip the image name if it is the image name
User-agent: Microsoft-Entourage/
On 29/8/07 01:43, "Horms" <horms@xxxxxxxxxxxx> wrote:

> On Tue, Aug 28, 2007 at 03:05:05AM -0700, Keir Fraser wrote:
>> Isn't that a kexec bug? Multiboot command lines include the image name in
>> all other cases. If there's no suitable name, perhaps a dummy name should be
>> included?
> I was wondering where it should be fixed. Do you know if
> supplying BOOT_IMAGE is part of the multiboot specification?

Ah, sorry, I forgot that you repro'ed this on IA64 which does not use
multiboot at all.

The problem here is, I believe, that the cooking of the command line to
strip the image name is actually an arch-specific operation. I notice that
e.g., Linux on IA64 does nto bother to do this at all. The fact that the
name is prefixed with BOOT_IMAGE= absolutely avoids any possible name clash
with cmdline parameters. Look at /proc/cmdline on a native IA64 Linux box
for example -- the image name is not stripped off.

What I will do is make arch/x86/setup.c strip the image name before calling
the generic parser. That should make IA64 much happier. Hopefully it will be
okay for PPC too.

 -- Keir

Xen-devel mailing list