This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 2/3] xencomm take 4: xen side multiple page suppo

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/3] xencomm take 4: xen side multiple page support
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Tue, 28 Aug 2007 15:45:56 +0100
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 28 Aug 2007 07:46:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070828061736.GA7841%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfpgiPcYjjM/lV1EdyEfAAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH 2/3] xencomm take 4: xen side multiple page support
User-agent: Microsoft-Entourage/
On 28/8/07 07:17, "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx> wrote:

> +static int
> +xencomm_ctxt_next(struct xencomm_ctxt *ctxt, int i)
> +{
> +    BUG_ON(i >= ctxt->nr_addrs);
> +    /* in i == 0 case, we already calculated in xecomm_addr_init() */
> +    if ( i != 0 )
> +        ctxt->address++;

This function may deserve a comment -- what is it for? The 'i == 0' comment
is confusing, and appears to refer to a function that doesn't exist (I
couldn't find any function with suffix _addr_init()).

These patches are all in the staging tree now, so provide delta patches to
apply on top.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>