This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH]: Don't ask for a VNC password after HVM live migrate

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH]: Don't ask for a VNC password after HVM live migrate
From: Chris Lalancette <clalance@xxxxxxxxxx>
Date: Mon, 27 Aug 2007 16:49:05 -0400
Delivery-date: Mon, 27 Aug 2007 13:49:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20070719)
     Attached is a simple patch to fix the VNC server in the qemu device model
after an HVM save/restore/migrate, if you don't have a vncpasswd specified.  The
basic problem was that the "image" section of the sxp had a "None" in it, which
means that on the restore (either on the local machine or remote machine), the
vnc server in the qemu device model literally needed the string "None" to
properly connect.  This simple patch only puts a vncpasswd entry in the image if
it is *not* None in the python code, thus avoiding the whole issue.

This patch is against 3.1.0, but should apply easily to xen-unstable.

Signed-off-by: Chris Lalancette <clalance@xxxxxxxxxx>
--- xen-3.1.0-src/tools/python/xen/xm/create.py.orig    2007-08-27 
16:41:39.000000000 -0400
+++ xen-3.1.0-src/tools/python/xen/xm/create.py 2007-08-27 16:42:44.000000000 
@@ -701,7 +701,8 @@ def configure_hvm(config_image, vals):
     for a in args:
         if (vals.__dict__[a]):
             config_image.append([a, vals.__dict__[a]])
-    config_image.append(['vncpasswd', vals.vncpasswd])
+    if vals.vncpasswd is not None:
+        config_image.append(['vncpasswd', vals.vncpasswd])
 def run_bootloader(vals, config_image):
     if not os.access(vals.bootloader, os.X_OK):
Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH]: Don't ask for a VNC password after HVM live migrate, Chris Lalancette <=