This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-ia64-devel] [PATCH][RFC] Fix error message for xm create command

To: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-ia64-devel] [PATCH][RFC] Fix error message for xm create command
From: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Date: Mon, 27 Aug 2007 16:21:41 +0900
Delivery-date: Mon, 27 Aug 2007 00:22:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx

When I tested xm create command, I saw the following error message. 
I expected an error message "Error: (12, 'Cannot allocate memory')" 
because I intentionally caused a memory shortage on the test. 
But the error message was different from my expectation. 

# xm create /xen/HVMdomain.1
Using config file "/xen/HVMdomain.1".
Error: an integer is required

I looked at xend.log to examine the cause why the error message was 
shown.  (Could you see the attached xend.log?) 
xend had the error message "Error: (12, 'Cannot allocate memory')" 
first.  But xend changed the error message to "Error: an integer is 
required" halfway. 
I'm not sure about the cause why an exception occurred in logging 
processing.  But when I applied an attached patch, I confirmed that 
the error message that I expected was shown.  The patch does not 
call xc.domain_destroy_hook() if self.domid is None. 

Could you comment on the patch?  I'd like to solve the problem 
because I think that users want correct error message. 

Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,

Attachment: xend.log
Description: Binary data

Attachment: domain_destroy_hook.patch
Description: Binary data

Xen-ia64-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>