This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] Xen i386 xen-head.S fix sections mixup (updated)

To: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Xen i386 xen-head.S fix sections mixup (updated)
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Mon, 20 Aug 2007 10:34:44 -0700
Cc: chrisw@xxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, jeremy@xxxxxxxxxxxxx
Delivery-date: Mon, 20 Aug 2007 10:35:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070820171912.GB9478@Krystal>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070820030420.GA11070@Krystal> <46C9311D.2030702@xxxxxxxx> <20070820171912.GB9478@Krystal>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20070719)
Mathieu Desnoyers wrote:
> Xen i386 xen-head.S fix sections mixup
> xen-head.S does not come back to the data section, leaving the text section
> as current section. It causes problems with a slightly enhanced DEBUG_RODATA
> that supports CONFIG_HOTPLUG and bringing a CPU up after the text has been
> marked read-only: reference to early_gdt_descr causes a page fault.
> Update:
> It should be using pushsection/popsection.

Looks good, with one caveat below.

Acked-by: Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>

> -     .section .text
> +.pushsection .text
>       ELFNOTE(Xen, XEN_ELFNOTE_GUEST_OS,       .asciz "linux")
>       ELFNOTE(Xen, XEN_ELFNOTE_GUEST_VERSION,  .asciz "2.6")
>       ELFNOTE(Xen, XEN_ELFNOTE_XEN_VERSION,    .asciz "xen-3.0")
> @@ -34,5 +35,6 @@ ENTRY(hypercall_page)
>       ELFNOTE(Xen, XEN_ELFNOTE_PAE_MODE,       .asciz "no")
>  #endif
>       ELFNOTE(Xen, XEN_ELFNOTE_LOADER,         .asciz "generic")
> +.popsection

Actually, the push/popsections around the ELFNOTEs are redundant;
ELFNOTE() does its own push/popsection to put things into the
appropriate .note* section anyway.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>