This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] small mca cleanup

To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] small mca cleanup
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 16 Aug 2007 17:06:55 +0100
Delivery-date: Thu, 16 Aug 2007 09:07:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2EA2BB1.144B0%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfgGhr+WbyW5EwNEdymygAX8io7RQABVwZ8
Thread-topic: [Xen-devel] [PATCH] small mca cleanup
User-agent: Microsoft-Entourage/
To be fair -- if you posted this as part of a fuller patchset to move us
away from Linux-synced files and towards a new fully thought-out method for
handling MCA/MCE then I'd have no problems with it (but maybe I would with
the patchset as a whole :-). It's just I see no sense in applying it in

 -- Keir

On 16/8/07 16:28, "Keir Fraser" <keir@xxxxxxxxxxxxx> wrote:

> Oh yeah, sure: Xen-specific stuff and the general MCE/MCA reworking that
> you're talking about are one thing. But there's no point in minor fixes and
> stylistic cleanups going into Xen and bypassing upstream Linux.
>  -- Keir
> On 16/8/07 16:14, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
>> On Thursday 16 August 2007 16:42:37 Keir Fraser wrote:
>>> The file you modify is from upstream Linux, and that's where this patch
>>> belongs.
>> oh, I have many changes in my queue in files that are from Linux
>> (and also new files, that are not in Linux).
>> They do one thing, that does not belong into Linux (or any other OS):
>> Notifying guests, preferably Dom0.
>> I'm about extracting the least intrusive changes first.
>> We can still push changes into Linux that belong to there.
>> For more information where this is going to, please see the
>> discussion "MCE/MCA concept" on this list. The thread started here:
>> http://lists.xensource.com/archives/html/xen-devel/2007-05/msg01015.html
>> Christoph
>>>  -- Keir
>>> On 16/8/07 15:36, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
>>>> Hi!
>>>> The MCG_CAP MSR never returns a negative count of available
>>>> error-reporting banks. Thus make nr_mce_banks  unsigned.
>>>> While here, do some other minor cleanups.
>>>> Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>