This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Event Channel API Oops

To: Adam Wick <awick@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Event Channel API Oops
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Tue, 14 Aug 2007 09:09:45 +0100
Delivery-date: Tue, 14 Aug 2007 01:10:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <EF76F643-7E99-47BB-A363-69F58DD3B16F@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfeSnl0t+ee/ko9EdyOtwAX8io7RQ==
Thread-topic: [Xen-devel] Event Channel API Oops
User-agent: Microsoft-Entourage/
On 13/8/07 23:02, "Adam Wick" <awick@xxxxxxxxxx> wrote:

> Several of the event channel API's (_bind_unbound_port,
> _bind_interdomain, _bind_virq, and _pending in xenctrl.h) state that
> they return -1 on error. As it turns out, however, the return value
> type (evtchn_port_t, which is uint32_t in event_channel.h) is
> unsigned. Thus, testing for < 0 on the return type will always fail,
> because there are no negative numbers for the type.
> I don't have a patch, because I'm not sure how you think this is best
> fixed, but just wanted to give you a heads up.

I'm happy to guarantee that an event channel identifier will always fit in
31 bits, and hence can be represented by 'int' type on any architectural ABI
that we potentially care about.

I'll do a patch.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>