This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] clean up vmx_world_restore and its comments.

To: "Keir Fraser" <keir@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] clean up vmx_world_restore and its comments.
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Tue, 14 Aug 2007 00:44:11 +0800
Delivery-date: Mon, 13 Aug 2007 09:44:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2E643AA.141D6%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <B30DA1341B0CFA4893EF8A36B40B5C5D01814E81@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C2E643AA.141D6%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfduaFp8Gbanf1SS1m6FgcICbDg0QADGmH7AABT2sA=
Thread-topic: [Xen-devel] [PATCH] clean up vmx_world_restore and its comments.
>+    /* guest setup page table in real mode, and enables PE, 
>then PG. */
>+    if ( !hvm_paging_enabled(v) && v->arch.hvm_vmx.vmxassist_enabled )
>+        v->arch.hvm_vcpu.guest_cr[3] = c->cr3;
>Any reason to gate this on vmxassist_enabled? Must you avoid modifying
>guest_cr[3] when switching into vmxassist mode?

No, this happens only when guest exits vmxassist mode.

>I'd really expect this code to just look a lot like vmx_vmcs_restore().
>is, update all of CR0-CR4, then unconditionally get a 
>reference on cr3 (if paging enabled) and drop old cr3 reference.

I think it is.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>