This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] [xen, xencomm] various xencomm fixes (was Re

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] [xen, xencomm] various xencomm fixes (was Re: [XenPPC] Re: [Xen-ia64-devel] [PATCH 1/2] remove xencomm page size limit(xen side))
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Mon, 13 Aug 2007 11:46:18 +0900
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Alex Williamson <alex.williamson@xxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 12 Aug 2007 19:46:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1186772087.7073.26.camel@basalt>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070731061019.GB6039%yamahata@xxxxxxxxxxxxx> <1185913517.6802.74.camel@bling> <20070801063654.GD14448%yamahata@xxxxxxxxxxxxx> <1185995274.15389.21.camel@basalt> <20070802024439.GB6395%yamahata@xxxxxxxxxxxxx> <1186066846.27484.7.camel@basalt> <20070803021242.GB17231%yamahata@xxxxxxxxxxxxx> <1186152196.17978.1.camel@diesel> <20070807084454.GB20189%yamahata@xxxxxxxxxxxxx> <1186772087.7073.26.camel@basalt>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/
On Fri, Aug 10, 2007 at 01:54:47PM -0500, Hollis Blanchard wrote:
> I don't see how we'd ever hit this case though, nor why we'd panic the
> domain. How could paddr_to_maddr() ever return an maddr that doesn't
> belong to the current domain? If paddr is invalid, an error should be
> returned from there and propagated up, which is better than killing the
> whole domain IMHO...

I agree with you that we should return an error instead of panicing domain.

After getting maddr, another vcpu of the domain can free the page
with the decrease reservation hypercall at the same time.
Please remember that Xen supports SMP and balloon.
Then when accessing the page of maddr, the page might be used 
for another purpose.
Such a domain behaviour doesn't make sense. Howerver nothing
prevents it.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>