This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix xm block/network-detach command (take2)

To: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix xm block/network-detach command (take2)
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Fri, 10 Aug 2007 16:08:23 -0600
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 10 Aug 2007 15:08:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <46BB61A3.7010903@xxxxxxxxxx> 29C7DB2CBD08C6kanno.masaki@xxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <46BB61A3.7010903@xxxxxxxxxx> 29C7DB2CBD08C6kanno.masaki@xxxxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20060911)
Masaki Kanno wrote:
> Hi Jim,
> Thanks for your tests.
>> I tested your patch briefly on c/s 15672.
> <snip>
>> The device was unplugged but its config not removed. From xend.log:
>> File "/usr/lib64/python2.4/xen/xend/XendDomainInfo.py", line 615, in
>> destroyDevice
>> self.info['%s_refs' % deviceClass].remove(dev_uuid)
>> KeyError: 'tap_refs'
>> I think refs for the various disk types all fall under 'vbd_refs'.
> I tested blktap with the same way as your operation.  But I did not 
> encounter the command error as follows. 
> But your thinking is right, so I wrote a small patch to remove the 
> error message.  Could you test the patch again? 

Looks good with your additional patch. Thanks.

>> The behavior is fine (i.e. the disk is still attached and remains in
>> stored config) but the error message is misleading. xvbd is connected,
>> its just the front-end won't let go AFAIK.
> I'd like to improve the error message.  Could you give me thinking 
> time about 2 weeks? 

Sure. I just noticed it while testing but spent no time investigating.


Xen-devel mailing list