This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][xend] Fix/cleanup destoryDevice code path

To: Mats Petersson <mats@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][xend] Fix/cleanup destoryDevice code path
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Fri, 03 Aug 2007 09:53:51 -0600
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 03 Aug 2007 08:51:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <46b22fc8.0422300a.6b61.fffffe9a@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <46B22A04.3000106@xxxxxxxxxx> <46b22fc8.0422300a.6b61.fffffe9a@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20060911)
Mats Petersson wrote:
> Jim
> Can you check if this removes the device nodes within xenstore when
> doing xm save [1] - as I modified this section of code to fix up a
> problem with just that not so long ago. Unfortunately, I'm not able to
> test it myself, as I'm "without a xen-capable machine at the moment".

Yes, everything gets nuked from xenstore as expected on save.

> I have no particular reason to believe it DOESN'T do that, I'm just
> asking to make sure that it's destroyed properly, because I found that
> leaving lots of device info in xenstore bloats the database in
> xenstore, and eventually Dom0 runs out of physical memory.... :-(

Yes, I recall this behavior.  I recently received a large database file
(~34M) from a 3.0.4-based system that includes your patches.  This
system had well over 25000 vms started/[stopped|destroyed|failed] and
the database had *many* /local/domain/<vmid>/device/console/0 entries. 
So some types of devices (console in particular) are still orphaned
under some yet undetermined vm lifeclycle event.  Trying to reproduce ...

BTW, any ideas on how to read a xenstore tdb file provided via a bug
report?  :-)


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>