This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][ELF] Correct space calculation for symtab when B

To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][ELF] Correct space calculation for symtab when BSD_SYMTAB=yes
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 02 Aug 2007 14:21:34 +0100
Delivery-date: Thu, 02 Aug 2007 06:19:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200708021426.59206.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfVCAvuSjtWCUD7Edy3iQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH][ELF] Correct space calculation for symtab when BSD_SYMTAB=yes
User-agent: Microsoft-Entourage/
On 2/8/07 13:26, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> What do the virtual addresses of the symtab/strtab sections have to
>> do with their location in the final address space, after loading? And since
>> you pack the sections into the domain address space in
>> elf_xen_dom_load_binary(), should you not simply sum the sizes of the
>> sections, then sstart=virt_kend and send=sstart+size_sum, rather than
>> taking max(end addresses in elf image) minus min(start addresses in elf
>> image).
> You're right. Attached is a patch, which does it that way.

Please try changeset 15679 in the -unstable staging tree. It's less code and
also fixed up to work with the domU domain builder too. Except it's not
actually been tested with a bsd_symtab guest kernel. It shouldn't need more
than a few lines of fixing to get it working though, if that.

 -- Keir

Xen-devel mailing list