WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [XenPPC] Re: [Xen-devel] Re: [Xen-changelog] [linux-2.6.18-xen] Add

To: Hollis Blanchard <hollisb@xxxxxxxxxx>
Subject: Re: [XenPPC] Re: [Xen-devel] Re: [Xen-changelog] [linux-2.6.18-xen] Add "#ifdef ARCH_HAS_DEV_MEM" to archtecture specific file_operations.
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Mon, 9 Jul 2007 16:23:26 -0400
Cc: Jun Kamada <kama@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir@xxxxxxxxxxxxx>, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 09 Jul 2007 13:21:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1184010064.26508.64.camel@basalt>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C2B84A7C.A8F1%keir@xxxxxxxxxxxxx> <1184010064.26508.64.camel@basalt>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Jul 9, 2007, at 3:41 PM, Hollis Blanchard wrote:

On Mon, 2007-07-09 at 20:26 +0100, Keir Fraser wrote:
On 9/7/07 20:20, "Hollis Blanchard" <hollisb@xxxxxxxxxx> wrote:

By the way, I wonder how PPC manages to build both drivers/char/ mem.c and drivers/xen/char/mem.c without ARCH_HAS_DEV_MEM? The model is supposed to be that mem_fops defined by the Xen file is picked up by the generic file. If !ARCH_HAS_DEV_MEM then that doesn't happen -- so who picks up the Xen
mem_fops?

Hmmm, yeah. Looks like we haven't tested that... :)

yeah, we have :)
xlate_dev_mem_ptr() works just fine for us, so drivers/char/mem.c just works and the xen version of the ops is never considered.

Actually we should be forcing CONFIG_XEN_DEVMEM, but the Makefile ignores it.
-JX

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>