WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] ARCH_HAS_DEV_MEM patch for Xwindow on IA64machin

To: <kama@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] ARCH_HAS_DEV_MEM patch for Xwindow on IA64machine
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 04 Jul 2007 13:04:50 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 04 Jul 2007 05:01:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070704203821.B340.KAMA@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070704203821.B340.KAMA@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Jun Kamada <kama@xxxxxxxxxxxxxx> 04.07.07 13:43 >>>
>We would like to support Xwindow on IA64 by remapping machine address to
>pseudo physical address at PCI device initialization (pci_acpi_scan_root()
>in arch/ia64/pci/pci.c) but at "mmap /dev/mem" systemcall.
>With the new scheme, we need no longer the archtecture specific memory
>operations described above.

You only talk about X - isn't it possible that there are other users of this 
interface?

Also,

>--- a/drivers/xen/Kconfig      Thu Jun 21 15:12:20 2007 +0900
>+++ b/drivers/xen/Kconfig      Thu Jun 21 15:13:21 2007 +0900
>@@ -273,4 +273,8 @@ config XEN_SMPBOOT
>       default y
>       depends on SMP
> 
>+config XEN_DEVMEM
>+      bool
>+      default y
>+
> endif

This seems pretty useless unless ia64 doesn't use drivers/xen/Kconfig (which
would be a mistake I think).

>--- a/drivers/xen/Makefile     Thu Jun 21 15:12:20 2007 +0900
>+++ b/drivers/xen/Makefile     Thu Jun 21 15:13:21 2007 +0900
>@@ -5,9 +5,9 @@ obj-y  += xenbus/
> obj-y += xenbus/
> obj-y += gntdev/
> obj-y += balloon/
>-obj-y += char/
> 
> obj-y += util.o
>+obj-$(CONFIG_XEN_DEVMEM)              += char/
> obj-$(CONFIG_XEN_BLKDEV_BACKEND)      += blkback/
> obj-$(CONFIG_XEN_BLKDEV_TAP)          += blktap/
> obj-$(CONFIG_XEN_NETDEV_BACKEND)      += netback/

This is certainly wrong. Even if driver/xen/char/ currently only has a
single file, you should descend into that directory. The conditional
(if needed at all) should then be in driver/xen/char/Makefile.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel