WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix balloon handling of highmem pages

To: Mark Williamson <mark.williamson@xxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix balloon handling of highmem pages
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sun, 01 Jul 2007 22:06:35 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, anthony@xxxxxxxxxxxxxxxxx
Delivery-date: Sun, 01 Jul 2007 14:04:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200706291653.14578.mark.williamson@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ace8I7UB89PENCgWEdyFZAAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Fix balloon handling of highmem pages
User-agent: Microsoft-Entourage/11.3.3.061214
Applied, but have you tested with 'mem=' on the domain cmdline to give it a
memmap bigger than its original allocation of memory? In this case it looks
like the code in mm/init-xen.c does the right thing in tandem with this
patch (i.e., it increments totalhigh_pages for each not-currently-present
page, and you then decrement again when the not-present pages get added to
the balloon). But I'm not 100% certain and it could do with being tested.

 Thanks,
 Keir

On 29/6/07 16:53, "Mark Williamson" <mark.williamson@xxxxxxxxxxxx> wrote:

> I knocked up a quick patch to fix the balloon driver's handling of highmem
> pages.  Should apply cleanly to the Linux dev tree.  I can also submit it for
> 3.1 if wanted.
> 
> Without this, LowTotal can go negative (given it's an unsigned integer) and
> then appears as ~4Gig, which is a bit silly.
> 
> I beliee this fixes Anthony Wright's bug #733 in Bugzilla
> (http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=733).  Credit to
> Anthony for noticing the problem, and figuring out that he was actually
> seeing an unsigned int going "negative".
> 
> Cheers,
> Mark



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>