| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [kvm-devel] [PATCH RFC 2/3] Virtio draft III: example ne
|
To: |
Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [kvm-devel] [PATCH RFC 2/3] Virtio draft III: example net driver |
|
From: |
Avi Kivity <avi@xxxxxxxxxxxx> |
|
Date: |
Mon, 25 Jun 2007 17:54:33 -0400 |
|
Cc: |
Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, Xen Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>, "jmk@xxxxxxxxxxxxxxxxxxx" <jmk@xxxxxxxxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, kvm-devel <kvm-devel@xxxxxxxxxxxxxxxxxxxxx>, virtualization <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Christian Borntraeger <cborntra@xxxxxxxxxx>, Latchesar Ionkov <lionkov@xxxxxxxx>, Suzanne McIntosh <skranjac@xxxxxxxxxx>, Brian King <brking@xxxxxxxxxxxxxxxxxx>, Martin Schwidefsky <schwidefsky@xxxxxxxxxx> |
|
Delivery-date: |
Mon, 25 Jun 2007 14:51:53 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20070625193304.GB25736@xxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<1181217762.14054.192.camel@xxxxxxxxxxxxxxxxxxxxx> <1181999552.6237.255.camel@xxxxxxxxxxxxxxxxxxxxx> <1181999669.6237.257.camel@xxxxxxxxxxxxxxxxxxxxx> <1181999825.6237.260.camel@xxxxxxxxxxxxxxxxxxxxx> <467FDEAD.4030204@xxxxxxxxxxxxxxxxxx> <20070625193304.GB25736@xxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 2.0.0.4 (X11/20070615) |
Christoph Hellwig wrote:
On Mon, Jun 25, 2007 at 10:26:37AM -0500, Brian King wrote:
1. The add_inbuf interface passes an sg list. This causes problems for
ibmveth since its rx buffers cannot be scatterlists.
I'm probably missing something. What is wrong with a scatterlist of
length 1?
2. The user of this API does not have access to the sk_buf. This causes
issues for ibmveth since it needs to reserve the first 8 bytes of the
rx buffer for use by the firmware. It currently uses skb_reserve to do this.
Would it be simpler to just pass an sk_buf rather than the scatterlist
on these interfaces for virtio_net users?
It probably should pass the sk_buff.
But virtio is a generic layer that is useful for more than just networking.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH RFC 3/3] Virtio draft III: example block driver, (continued)
- [Xen-devel] Re: [PATCH RFC 3/3] Virtio draft III: example block driver, Avi Kivity
- [Xen-devel] Re: [PATCH RFC 3/3] Virtio draft III: example block driver, Rusty Russell
- [Xen-devel] Re: [PATCH RFC 3/3] Virtio draft III: example block driver, Avi Kivity
- [Xen-devel] Re: [PATCH RFC 3/3] Virtio draft III: example block driver, Rusty Russell
- [Xen-devel] Re: [PATCH RFC 3/3] Virtio draft III: example block driver, Avi Kivity
- [Xen-devel] Re: [PATCH RFC 2/3] Virtio draft III: example net driver, Brian King
- [Xen-devel] Re: [kvm-devel] [PATCH RFC 2/3] Virtio draft III: example net driver, Christoph Hellwig
- [Xen-devel] Re: [kvm-devel] [PATCH RFC 2/3] Virtio draft III: example net driver,
Avi Kivity <=
- [Xen-devel] Re: [kvm-devel] [PATCH RFC 2/3] Virtio draft III: example net driver, Brian King
- [Xen-devel] Re: [kvm-devel] [PATCH RFC 2/3] Virtio draft III: example net driver, Avi Kivity
- [Xen-devel] Re: [PATCH RFC 2/3] Virtio draft III: example net driver, Rusty Russell
- [Xen-devel] Re: [PATCH RFC 2/3] Virtio draft III: example net driver, Brian King
[Xen-devel] Re: [kvm-devel] [PATCH RFC 0/3] Virtio draft III, Avi Kivity
|
|
|
| |
|
Home