This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch v2] static and __init symbols in machine_kexec.c
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Wed, 16 May 2007 16:58:52 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Delivery-date: Wed, 16 May 2007 00:57:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070516073132.GA8298@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1179298159.23300.1@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <C2706F95.770D%Keir.Fraser@xxxxxxxxxxxx> <20070516073132.GA8298@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: mutt-ng/devel-r804 (Debian)
On Wed, May 16, 2007 at 04:31:33PM +0900, Simon Horman wrote:
> On Wed, May 16, 2007 at 08:21:41AM +0100, Keir Fraser wrote:
> > 
> > 
> > 
> > On 16/5/07 07:49, "Simon Horman" <horms@xxxxxxxxxxxx> wrote:
> > 
> > > Curiously, making xen_max_nr_phys_cpus __init causes a section missmatch
> > > error at compile time. I guess this is to do with the way global ints
> > > are handled. I confirmed that its consistent across x86_32, x86_64 and
> > > ia64. So I guess its ok to leave it as is.
> > 
> > What if you make it __initdata, as it (and the other data variables) should
> > be?
> I'll take a look into that and get back to you.

That ideed does solve the problem, silly me.
I'll send an updated patch in a moment.

  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

Xen-devel mailing list