xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] 2/4 "nemesis" scheduling domains for Xen

from [Mark Williamson]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx, ncmike@xxxxxxxxxx
Subject:	Re: [Xen-devel] [PATCH] 2/4 "nemesis" scheduling domains for Xen
From:	Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date:	Mon, 7 May 2007 20:58:00 +0100
Delivery-date:	Mon, 07 May 2007 12:57:27 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20070504222432.GC26054@xxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<20070504222432.GC26054@xxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	KMail/1.9.6

Hi Mike,

A couple of minor coding style quibbles.  I'll leave actually design comments 
to those who've worked on the scheduler more recently than I!

As Keir said, there's a few minor formatting differences from the Xen code 
(e.g. spacing around the brackets in if statements).  I'd like to add that in 
Xen code that isn't shared with Linux, NULL is preferred to 0 when assigning 
to a pointer.  Applying this patch and running it through sparse through 
sparse gave me:

> sched_credit.c:457:18: warning: Using plain integer as NULL pointer
> sched_credit.c:998:18: warning: Using plain integer as NULL pointer

Only a minor nit.

Cheers,
Mark

-- 
Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] 2/4 "nemesis" scheduling domains for Xen, Mike D. Day Re: [Xen-devel] [PATCH] 2/4 "nemesis" scheduling domains for Xen, Keir Fraser Re: [Xen-devel] [PATCH] 2/4 "nemesis" scheduling domains for Xen, Mark Williamson <=

Previous by Date:	Re: [Xen-devel] vesafb, ron minnich
Next by Date:	RE: [Xen-devel] vesafb, Ian Pratt
Previous by Thread:	Re: [Xen-devel] [PATCH] 2/4 "nemesis" scheduling domains for Xen, Keir Fraser
Next by Thread:	[Xen-devel] [PATCH] 3/4 "nemesis" scheduling domains for Xen, Mike D. Day
Indexes:	[Date] [Thread] [Top] [All Lists]