WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] 32on64 vCPU cleanup fix

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 32on64 vCPU cleanup fix
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 26 Apr 2007 18:36:50 +0100
Delivery-date: Thu, 26 Apr 2007 10:35:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4630E786.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceIKXh/ttz6kfQcEduB4QAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] 32on64 vCPU cleanup fix
User-agent: Microsoft-Entourage/11.3.3.061214
On 26/4/07 16:55, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Since vcpu_destroy_pagetables() clears v->arch.guest_table for hvm vCPUs,
> it must be avoided to free the page with MFN zero.

Up to yesterday there was never a case that we'd have an HVM vcpu with
IS_COMPAT()==1 (although there was some code that tried to handle this
case). Now that we support this there's a general need for a cleanup so that
code that is compat-mode-dependent explicitly checks for PV vs. HVM if that
matters to it.

I've applied an initial general fix as c/s 14961:f18e1ca6. I think
everything else is okay, but I'm not 100% sure about shadow code (although
that was one place that was explicitly checking for PV 32bit guests where it
cared, so I hope it's okay).

Please take a look and make sure I'm not very confused about what's going
on. :-)

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>