Re: [Xen-devel] A different probklem with save/restore on C/S 14823.

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 13/4/07 18:24, "Petersson, Mats" <Mats.Petersson@xxxxxxx> wrote:

> However, my guest does A LOT of IOIO exits (it's an IDE test-app), with
> some HLT and IRQ exits thrown in for good measure. So if the guest is
> doing IOIO exit it would end up in platform.c:844 before it gets to
> hvm_do_resume?  Or are you saying that we should crash as soon as the
> guest restarts, because that's done through hvm_do_resume?

Exactly. hvm_do_resume() should always be executed when an HVM VCPU gets
scheduled onto a physical CPU (it's part of the schedule_tail). So it should
execute before your first vmentry, and hence before your first vmexit. And
shared_page_va is sticky: once it's set it stays set. It shouldn't ever get
zapped to zero while a guest is running.

> Would a check for zero in get_vio() with domain_crash_synchronous() be a
> "good thing" here, or is that too time-consuming in a relatively
> time-critical path of HVM?

Could do. But hvm_do_resume() is the one to concentrate on.

 -- Keir

> I will look at it on Monday (before I update to the new version, just to
> make sure I can reproduce it still ;-) ).



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel