This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] pciback: check function return values

To: "Chris Bookholt" <cgbook2@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pciback: check function return values
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 04 Apr 2007 08:53:13 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 04 Apr 2007 00:51:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4612793B.5060406@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <460A7D47.76E4.0078.0@xxxxxxxxxx> <4612793B.5060406@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Chris Bookholt <cgbook2@xxxxxxxxxxxxxx> 03.04.07 17:56 >>>
>Jan Beulich wrote:
>> .. of functions declared with __must_check post-2.6.18.
>> (As a note - I'm getting the impression that when used as a module, pciback
>> appears to have a number of memory leaks).
>Jan, thanks for the added robustness by way of return value checking.
>What gives you the impression there are memory leaks when pciback is
>loaded as a module?  The more specific you can be the easier problems
>are to find and fix.

First thing pcistub_init() does is parse the hide option, calling
pcistub_device_id_add(). If subsequent steps fail, or if the driver is unloaded,
this isn't being cleaned up. There are others that look suspicious, but this is
certainly easier to determine for someone more familiar with the code than
I am.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>