WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix build when bcc is not installed

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix build when bcc is not installed
From: Brendan Cully <brendan@xxxxxxxxx>
Date: Fri, 16 Mar 2007 16:13:28 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 16 Mar 2007 16:12:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C220C568.47D9%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: keir@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <0712e96990851f278a2a.1174080213@xxxxxxxxxxxxxxxxx> <C220C568.47D9%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.14 (2007-03-15)
On Friday, 16 March 2007 at 22:06, Keir Fraser wrote:
> How does your build fail without this patch? I tested building with no bcc
> and it works fine for me. Perhaps it depends on particular version of cut or
> awk?

I don't have the exact text on me, but it was something like

syntax error: ''

How does your shell handle $((''))? Mine doesn't like it. I'd guess
this is a case of ubuntu's recent attempt to make sh more posix-pure.

> On 16/3/07 21:23, "Brendan Cully" <brendan@xxxxxxxxx> wrote:
> 
> > # HG changeset patch
> > # User Brendan Cully <brendan@xxxxxxxxx>
> > # Date 1174080142 25200
> > # Node ID 0712e96990851f278a2a27ef7f15b09bbff050c5
> > # Parent  b6272addce8cd744e31a666672fa38bf5b27ffb3
> > Fix build when bcc is not installed
> > 
> > diff -r b6272addce8c -r 0712e9699085 tools/firmware/Makefile
> > +++ b/tools/firmware/Makefile Fri Mar 16 14:22:22 2007 -0700
> > @@ -14,7 +14,7 @@ SUBDIRS += hvmloader
> >  
> >  .PHONY: all
> >  all:
> > - @set -e; if [ $$((`bcc -v 2>&1 | grep version | cut -d' ' -f 3 | awk -F. 
> > '{
> > printf "0x%02x%02x%02x", $$1, $$2, $$3}'`)) -lt $$((0x00100e)) ] ; then \
> > + @set -e; if [ $$((`( bcc -v 2>&1 | grep version || echo 0.0.0 ) | cut -d' 
> > '
> > -f 3 | awk -F. '{ printf "0x%02x%02x%02x", $$1, $$2, $$3}'`)) -lt
> > $$((0x00100e)) ] ; then \
> > echo "***********************************************************"; \
> > echo "Require dev86 package version >= 0.16.14 to build firmware!"; \
> > echo "(visit http://www.cix.co.uk/~mayday for more information)"; \
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>