|
xen-devel
[Xen-devel] Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation
|
To: |
Chris Wright <chrisw@xxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [patch 20/26] Xen-paravirt_ops: Core Xen implementation |
|
From: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Date: |
Fri, 16 Mar 2007 09:44:25 -0700 |
|
Cc: |
Zachary Amsden <zach@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Adrian Bunk <bunk@xxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx> |
|
Delivery-date: |
Fri, 16 Mar 2007 09:43:42 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20070316163338.GI10574@xxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20070301232443.195603797@xxxxxxxx> <20070301232528.812011702@xxxxxxxx> <20070316091411.GF23174@xxxxxxx> <20070316163338.GI10574@xxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 1.5.0.10 (X11/20070302) |
Chris Wright wrote:
> * Ingo Molnar (mingo@xxxxxxx) wrote:
>
>> * Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
>>
>>
>>> Core Xen Implementation
>>>
>>> This patch is a rollup of all the core pieces of the Xen
>>> implementation, including booting, memory management, interrupts, time
>>> and so on.
>>>
>>> --- a/arch/i386/kernel/head.S
>>> +++ b/arch/i386/kernel/head.S
>>> @@ -535,6 +535,10 @@ unhandled_paravirt:
>>> ud2
>>> #endif
>>>
>>> +#ifdef CONFIG_XEN
>>> +#include "../xen/xen-head.S"
>>> +#endif
>>>
>> i'd suggest to remove the #ifdef and push it into xen-head.S.
>>
>
> That's been fixed, the two are built as seperate objects now.
>
Actually, we tried it but it causes bad kernel images with some
binutils, so it has to be included for now.
>>> @@ -437,9 +437,9 @@ static unsigned long native_store_tr(voi
>>>
>>> static void native_load_tls(struct thread_struct *t, unsigned int cpu)
>>> {
>>> -#define C(i) get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + i] =
>>> t->tls_array[i]
>>> - C(0); C(1); C(2);
>>> -#undef C
>>> + get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + 0] = t->tls_array[0];
>>> + get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + 1] = t->tls_array[1];
>>> + get_cpu_gdt_table(cpu)[GDT_ENTRY_TLS_MIN + 2] = t->tls_array[2];
>>> }
>>>
>> this is a cleanup unrelated to the purpose of the patch.
>>
>
> Sure, will split out.
>
Already done in Rusty's cleanup patch.
J
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home