 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] Error in XendCheckpoint: failed to flush file
| To: | "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] Error in XendCheckpoint: failed to flush file |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Wed, 28 Feb 2007 18:20:15 +0000 |
| Delivery-date: | Wed, 28 Feb 2007 10:19:42 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <342BAC0A5467384983B586A6B0B3767104DC3923@xxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcdbBqwu6tNHM8b5Edu40AAWy6hiGQAL/KvwAAlrrsgAAboRYAAAeHSK |
| Thread-topic: | [Xen-devel] Error in XendCheckpoint: failed to flush file |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 28/2/07 18:07, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx> wrote: > OK. Do you think it's worth checking the fd type with stat and only > doing the flush/fadvise if it's not a socket? My guess is probably not. I think fsync/fadvise/lseek are all well-defined to fail without trashing things if passed a socket. There's no reason to suspect that doing a stat() will be any quicker than just letting the fsync() or fadvise() fail. I've checked in some cleanups in this area as c/s 14176:d66dff0933. Hopefully it'll be in the public tree rsn, assuming I've fixed save/restore sufficently well! -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [Xen-devel] xen strace analysis, Sanjam Garg |
|---|---|
| Next by Date: | RE: [Xen-devel] xen strace analysis, Petersson, Mats |
| Previous by Thread: | RE: [Xen-devel] Error in XendCheckpoint: failed to flush file, Graham, Simon |
| Next by Thread: | Re: [Xen-devel] Error in XendCheckpoint: failed to flush file, Stefan Berger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
