WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 0/3][IA64] Accelerate IDE PIO on HVM/IA64

To: Kouya SHIMURA <kouya@xxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 0/3][IA64] Accelerate IDE PIO on HVM/IA64
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Tue, 27 Feb 2007 09:51:18 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 27 Feb 2007 08:50:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200702270850.l1R8oeK3019985@xxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <200702270850.l1R8oeK3019985@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2007-02-27 at 18:34 +0900, Kouya SHIMURA wrote:
> Hi,
> 
> This set of patches remarkably accelerates IDE PIO on HVM/IA64.
> I got a throughput of 2.11MB/sec in disk read performance.
> Without it, it was only 64kB/sec.
> 
> I posted the prototype once. 
> http://lists.xensource.com/archives/html/xen-devel/2006-12/msg00077.html
> 
> The basic idea is to add a buffering mechanism in a hypervisor.
> I know this approach is not sophisticated. But there is no other
> good way in IA64 which has no string instructions like x86's.

   This seems like a pretty good performance increase for only a single
page of domain overhead in Xen.  My main concern would be that we
maintain correctness.  It is writing out the dirty buffer before the
domain shuts down, right?  I'm guessing the flush probably does that.
Looks like a bug here though:

+static inline void
+buffered_pio_write(IDEState *s, uint32_t addr, int size)
+{
+    struct pio_buffer *piobuf = piobuf_by_addr(addr);
+    uint32_t data_end;
+
+    if (!piobuf)
+        return;
+    buffered_pio_flush(piobuf);
+    data_end = s->data_end - s->data_ptr - size;
+    if (data_end <= 0)
+        data_end = 0;

   data_end is unsigned, so it will never be < 0.  Same problem on the
read func.  Thanks,

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel