WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump

To: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump on Dom0
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Fri, 23 Feb 2007 16:28:35 +0000
Delivery-date: Fri, 23 Feb 2007 08:27:59 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <342BAC0A5467384983B586A6B0B3767104BE0A95@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdO73yfygbdSnxbR/2AnMRpBcbdNgAy2MewAXo9PloACVlAIAAAS21yAGSDywAAAszgRQ==
Thread-topic: [Xen-devel] [PATCH][TOOLS] Reducing impactofdomainsave/restore/dump on Dom0
User-agent: Microsoft-Entourage/11.2.5.060620
On 23/2/07 15:13, "Graham, Simon" <Simon.Graham@xxxxxxxxxxx> wrote:

> Take 3 -- I've moved the flushing/fadvise-ing code into a common routine
> -- the only way I found to do this in line with other utilities was to
> make it inline in xc_private.h (since this is the only file included in
> both libxenctrl and libxenguest). The 'ifdef __linux__' stuff is now
> confined to this routine which is better...
> 
> I've also left the fsync() in place -- I think it is necessary (and
> certainly does no harm).

Looks better. What is the -D_GNU_SOURCE for? It should probably at least be
limited to CFLAGS-$(CONFIG_Linux). And is it really needed in
xcutil/Makefile as well: if it's needed at all it should suffice to use it
when building the library that xcutil links against I would have thought?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>