WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Redundant piece of code in xc_hvm_bulid.c

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Redundant piece of code in xc_hvm_bulid.c
From: "Guy Zana" <guy@xxxxxxxxxxxx>
Date: Wed, 31 Jan 2007 10:42:47 -0500
Delivery-date: Wed, 31 Jan 2007 07:42:55 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdFTnTweciyUttvTxaHyb2jwFnxzQ==
Thread-topic: Redundant piece of code in xc_hvm_bulid.c
This piece of code is redundant:
(tools/libxc/xc_hvm_bulid.c) function setup_guest()
 
"""
if ( (v_end - v_start) > ((unsigned long long)nr_pages << PAGE_SHIFT) )
{
    PERROR("Initial guest OS requires too much space: "
           "(%lluMB is greater than %lluMB limit)\n",
           (unsigned long long)(v_end - v_start) >> 20,
           ((unsigned long long)nr_pages << PAGE_SHIFT) >> 20);
    goto error_out;
}
"""
 
Both of the expressions will always have the same value :)
 

Guy Zana.

____________

Team Leader,

Neocleus, Inc.

 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] Redundant piece of code in xc_hvm_bulid.c, Guy Zana <=