WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/3] Use string bound functions (take #2)

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH 1/3] Use string bound functions (take #2)
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Mon, 29 Jan 2007 15:51:01 +0100
Cc: Anil Madhavapeddy <anil@xxxxxxxxxxxxx>
Delivery-date: Mon, 29 Jan 2007 06:50:59 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1B6A3F76-2E6E-46B4-BAA5-B308294E8175@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: AMD / OSRC
References: <200701291525.18001.Christoph.Egger@xxxxxxx> <1B6A3F76-2E6E-46B4-BAA5-B308294E8175@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.4
On Monday 29 January 2007 15:37, Anil Madhavapeddy wrote:
> I notice these aren't checking for buffer truncation.  Might be worth
> putting checks for this in places where it matters and not silently
> truncate the string (e.g. the domain builder).

Yeah. I think, this should be done in another patch. Most important is,
that strlcpy() is used rather strncpy().

Christoph

>
> -anil
>
> On 29 Jan 2007, at 14:25, Christoph Egger wrote:
> > <xen_stringbound.diff>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>