WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-staging] [xen-unstable] Fix failure to localise xm

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-staging] [xen-unstable] Fix failure to localise xm by preventing cd from writing to stdout
From: Aron Griffis <aron@xxxxxx>
Date: Mon, 22 Jan 2007 18:39:07 -0500
Delivery-date: Mon, 22 Jan 2007 15:40:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200701221708.l0MH8J99018555@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: xen-devel@xxxxxxxxxxxxxxxxxxx
References: <200701221708.l0MH8J99018555@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)
Keir,

I think this is the wrong fix.  Rather you shouldn't be exporting
CDPATH to the environment.  It's useful only to your interactive shell
and shouldn't be passed on to scripts, builds, etc.  Lots of scripts
use "cd" in command substitution without explicitly throwing away
stdout.

Aron

Xen staging patchbot-unstable wrote:  [Mon Jan 22 2007, 12:08:18PM EST]
> # HG changeset patch
> # User kfraser@xxxxxxxxxxxxxxxxxxxxx
> # Date 1169485636 0
> # Node ID dd55107d4a679512c08d2c426f4876f424a3ae93
> # Parent  200a9c6deeb3947f3c0e4727aa0074de6acfdb7e
> Fix failure to localise xm by preventing cd from writing to stdout
> which gets incorrectly captured as a value for the bash for loop.
> Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>
> ---
>  tools/python/Makefile |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -r 200a9c6deeb3 -r dd55107d4a67 tools/python/Makefile
> --- a/tools/python/Makefile   Mon Jan 22 16:27:03 2007 +0000
> +++ b/tools/python/Makefile   Mon Jan 22 17:07:16 2007 +0000
> @@ -8,7 +8,7 @@ build:
>  build:
>       CC="$(CC)" CFLAGS="$(CFLAGS)" python setup.py build
>       if which $(MSGFMT) >/dev/null ; then \
> -          for file in `cd xen/xm; find messages -name xen-xm.po`; do \
> +          for file in `cd ./xen/xm; find messages -name xen-xm.po`; do \
>              dest=`echo "build/$$file" | \
>                    sed -e 's#xen-xm.po#LC_MESSAGES/xen-xm.mo#'`; \
>              mkdir -p `dirname "$$dest"`; \
> 
> _______________________________________________
> Xen-staging mailing list
> Xen-staging@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-staging
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] Re: [Xen-staging] [xen-unstable] Fix failure to localise xm by preventing cd from writing to stdout, Aron Griffis <=