WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 7/8] HVM save restore: shadow fix

To: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 7/8] HVM save restore: shadow fix
From: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Date: Thu, 18 Jan 2007 16:31:13 +0000
Cc: Ian Pratt <Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 18 Jan 2007 08:30:50 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070111141231.GA2909@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070111141231.GA2909@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)
At 22:12 +0800 on 11 Jan (1168553551), Zhai, Edwin wrote:
> [PATCH 7/8] HVM save restore: shadow fix
> 
> Signed-off-by: Zhai Edwin <edwin.zhai@xxxxxxxxx>
> 
> fix 2 shadow issues:
> * restored guest's mem type_info are not correct

In what way?  And why are you fixing that in the shadow
pagetable-promotion path rather than the restore path?  
If the pagetable pages are wrong, are other pages wrong too?

> +    {
> +        struct page_info *page = mfn_to_page(gmfn);
> +        /* XXX: add it to emulate a touched page */
> +        if ((page->u.inuse.type_info & PGT_type_mask) == PGT_none){
> +            page->u.inuse.type_info |= (PGT_writable_page | PGT_validated);
> +        }
> +    }
> +

Should this be gated to only happen to HVM guests?

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>