| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [patch 20/20] XEN-paravirt: Add Xen virtual block device
|
To: |
Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [patch 20/20] XEN-paravirt: Add Xen virtual block device driver. |
|
From: |
Muli Ben-Yehuda <muli@xxxxxxxxxx> |
|
Date: |
Sun, 14 Jan 2007 13:24:12 +0200 |
|
Cc: |
Andrew Morton <akpm@xxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Christian Limpach <Christian.Limpach@xxxxxxxxxxxx> |
|
Delivery-date: |
Sun, 14 Jan 2007 03:23:53 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<Pine.LNX.4.61.0701141202050.26276@xxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20070113014539.408244126@xxxxxxxx> <20070113014649.256179743@xxxxxxxx> <Pine.LNX.4.61.0701141202050.26276@xxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.5.11 |
On Sun, Jan 14, 2007 at 12:05:13PM +0100, Jan Engelhardt wrote:
> >+ (void)xenbus_switch_state(info->xbdev, XenbusStateConnected);
>
> Cast remove, if xenbus_switch_state does not have __must_check.
> Also elsewhere.
Hmm, why? this way you know that the programmer isn't checking the
return value *on purpose*. More information is good.
Cheers,
Muli
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home